Conversation
javorosas
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add runtime coverage confirming cancellation.last_checked hydrates to a Date.
Review effort: Lite
Findings: None
What changed in this PR
Updates SDK 6.0 to hydrate ISO response dates as Date objects while preserving SAT wall-clock timestamps and caller metadata.
Changes:
- Added centralized date hydration for API responses and validated webhooks.
- Updated nullable and newly exposed date types.
- Added runtime/type tests and documented the breaking release.
| File | Description |
|---|---|
test/web/runtime-compat.web.test.ts |
Tests browser date hydration. |
test/node/signed-download-urls.node.test.ts |
Tests signed URL dates. |
test/node/runtime-compat.node.test.ts |
Tests Node response and webhook hydration. |
test-d/runtime-types.test-d.ts |
Verifies updated TypeScript types. |
src/wrapper.ts |
Adds centralized response date hydration; coverage is needed for cancellation.last_checked. |
src/types/retention.ts |
Aligns retention date types. |
src/types/organization.ts |
Aligns organization date types. |
src/types/invoice.ts |
Updates nullable and cancellation date types. |
src/types/common.ts |
Updates shared date types. |
src/tools/webhooks.ts |
Hydrates locally validated webhook events. |
package.json |
Bumps version to 6.0.0. |
CHANGELOG.md |
Documents breaking changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Atendí la observación general de Copilot en |
javorosas
added this pull request to stack #122
September 29, 2026 15:46
Member
Author
javorosas
removed this pull request from stack #122
September 30, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release coordination
This PR contains only the date/type correction and its tests. The SDK 6.0 version bump, changelog, dependency updates, ESLint configuration, and ESM/CommonJS packaging are in a separate PR based on this branch. Merge this PR first, then the release PR; these changes require a major release.
Validation